This repository has been archived by the owner on Mar 8, 2023. It is now read-only.
MAPSJS: Support dynamic overlays using dynamic attributes. #2171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomicsulfate
force-pushed
the
MAPSJS-2783_DynamicTextureSupport
branch
9 times, most recently
from
b4f72fb
to
6ecaa25
Compare
Textures can now be changed without tile reloading. An expression with dynamic attributes can be used for textures. To change the texture, the dynamic attribute can be set to an image URL, an HTMLImageElement or an HTMLCanvasElement. Signed-off-by: Andres Mandado <[email protected]>
Signed-off-by: Andres Mandado <[email protected]>
atomicsulfate
force-pushed
the
MAPSJS-2783_DynamicTextureSupport
branch
2 times, most recently
from
d498516
to
cb8a71c
Compare
atomicsulfate
commented
Apr 20, 2021
atomicsulfate
commented
Apr 20, 2021
atomicsulfate
force-pushed
the
MAPSJS-2783_DynamicTextureSupport
branch
from
cb8a71c
to
fdf255a
Compare
Signed-off-by: Andres Mandado <[email protected]>
atomicsulfate
force-pushed
the
MAPSJS-2783_DynamicTextureSupport
branch
from
fdf255a
to
d212e2f
Compare
germanz
reviewed
Apr 22, 2021
| @@ -35,6 +35,10 @@ export interface StyledProperties { | |||
| [name: string]: Expr | StylePropertyEvaluator | Value | undefined; | |||
| } | |||
|
|
|||
| function isTextureProperty(propertyName: string): boolean { | |||
| return propertyName === "map" || propertyName.endsWith("Map"); | |||
There was a problem hiding this comment.
Which properties are we targetting with this, lightMap/aoMap, etc from Material? Isn't it safer to maintain a list of property names instead?
texture in material. Signed-off-by: Andres Mandado <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2171 +/- ##
==========================================
+ Coverage 68.27% 68.43% +0.15%
==========================================
Files 299 299
Lines 26469 26516 +47
Branches 5993 6006 +13
==========================================
+ Hits 18073 18146 +73
+ Misses 8396 8370 -26
Continue to review full report at Codecov.
|
- Use explict list of texture property names for techniques. - Add map property to fill technique so that technique can be used for overlays in jsapi. Signed-off-by: Andres Mandado <[email protected]>
atomicsulfate
force-pushed
the
MAPSJS-2783_DynamicTextureSupport
branch
from
8e16665
to
9a1cec8
Compare
Signed-off-by: Andres Mandado <[email protected]>
atomicsulfate
force-pushed
the
MAPSJS-2783_DynamicTextureSupport
branch
from
eb967f1
to
705cb96
Compare
germanz
approved these changes
Apr 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Textures can now be changed without tile reloading. An expression with
dynamic attributes can be used for textures. To change the texture,
the dynamic attribute can be set to an image URL, an HTMLImageElement
or an HTMLCanvasElement.